Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal log - minor fixes & improvements #13

Closed
testdev123456 opened this issue Jan 24, 2021 · 4 comments
Closed

terminal log - minor fixes & improvements #13

testdev123456 opened this issue Jan 24, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@testdev123456
Copy link

  • if emoji=False there's still a \u2192 ( → ) print on most lines. that should be gone.
  • the entire line print of "claiming the bonus for..." is redundant and unnecessary. we already see the +50 claim line.
  • the " Streamer: " is also redundant as well, as they're all streamers.
  • prediction lines should mention streamer's name, or at least on the first line "Start betting for.."
  • I think total channel_points is important to add. it doesn't take much space.
    like: time - +50 - username - total - reason

;o)

@testdev123456 testdev123456 added the bug Something isn't working label Jan 24, 2021
@Tkd-Alex
Copy link
Owner

Tkd-Alex commented Jan 24, 2021

if emoji=False there's still a \u2192 ( → ) print on most lines. that should be gone.

Are you on Window? 😢 Or just you don't want the arrow?

@Tkd-Alex Tkd-Alex reopened this Jan 24, 2021
@Tkd-Alex
Copy link
Owner

Tkd-Alex commented Jan 24, 2021

I miss-clicked the close button on this issue 😥
Here the current status of this issue:

  • if emoji=False there's still a \u2192 ( → ) print on most lines. that should be gone.
    Done Use --> instead of the arrow. 9f7ff0b

  • the entire line print of "claiming the bonus for..." is redundant and unnecessary. we already see the +50 claim line.
    Removed

  • the " Streamer: " is also redundant as well, as they're all streamers.
    Removed

  • prediction lines should mention streamer's name, or at least on the first line "Start betting for.."
    Edit for complete and start bet event

  • Start betting for {event} owned by {event.streamer}

  • Going to complete bet for {event} owned by {event.streamer}

  • I think total channel_points is important to add. it doesn't take much space.
    Edited with: {streamer-name} (xxxx points)

Tkd-Alex added a commit that referenced this issue Jan 24, 2021
…tor in channel points. Remove 'Streamer:'. Add channel points. Add Streamer name in bet event. Hide claim the bonus. Current status: #13 (comment)
@testdev123456
Copy link
Author

testdev123456 commented Jan 24, 2021

yes, unfortunately i'm on windows! and don't see the emojis. I would have liked to have them.. ;o(

  • Instead of the arrow what should be? --> sounds perfect

thanksss!!
(btw... i'm experiencing errors on raids since last night.. maybe it's just me.. I'll wait a little.. )

@Tkd-Alex
Copy link
Owner

(btw... i'm experiencing errors on raids since last night.. maybe it's just me.. I'll wait a little.. )

Should be fixed in the latest related commit, this bug It's present only in the Watch Streak branch

Seillama pushed a commit to Seillama/Twitch-Channel-Points-Miner-v2 that referenced this issue Oct 26, 2021
…tor in channel points. Remove 'Streamer:'. Add channel points. Add Streamer name in bet event. Hide claim the bonus. Current status: Tkd-Alex/Twitch-Channel-Points-Miner-v2#13 (comment)
Seillama referenced this issue in Seillama/Twitch-Channel-Points-Miner-v2 Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants